Fixrleak: Fixing Java Resource Leaks with GenAI

https://www.uber.com/blog/fixrleak-fixing-java-resource-leaks-with-genai/

by carimura • 1 year ago

17 15 1 year ago

stevoski• 1 year ago

“Resource leaks, where resources like files, database connections, or streams aren’t properly released after use, are a persistent issue in Java applications”

This was true maybe back in 2005. Java has had try-with-resources for a loooong time. As I see it this has been the dominant idiom for ages, for handling resources that might leak.

okr• 1 year ago

People tend to forget. Stream-API is a good candidate, that people like to not consider for leakage. If you don't own your stream, if you do not definitly know, that your stream comes from a collection, then ya better close it with a try-block.

bob778• 1 year ago

How much effort was spent automating this to fix 112 instances across Uber’s code base? I assume code reviews would catch any new issues so this seems like overkill for a small one-off task?

hawk_• 1 year ago

Spotbugs or checkstyle etc... would catch these. What does AI add here?

xyst2• 1 year ago

It gives marketing team at Uber to say "wE uSe AI hErE!!1". C-levels approve since anything AI gets a nice pump.

Engineering wise. This adds nothing. It’s an absolute waste of compute and energy to run this through LLMs

sigotirandolas• 1 year ago

This analysis ensures that FixrLeak skips functions where resources are passed as parameters, returned, or stored in fields, as these resources often outlive the function’s scope.
FixrLeak delivers precise, reliable fixes while leaving more complex cases for advanced analysis at the caller level.

In other words, this will only fix trivial leaks, which are best seen as a language design issue and can be fixed by RAII, reference counting, etc.

It won't fix the more insidious leaks like `UNBOUNDED_QUEUE.add(item)` that are more likely to pass through code review in the first place.

xyst2• 1 year ago

Using AI when a static scanner like SonarQube easily picks up these types of resource leaks, especially in Java.

Peak waste.

What’s next?

"Get rid of your GitHub dependabot alerts and replace it with my shitty ChatGPT wrapper”

rvz2• 1 year ago

Using AI when a static scanner like SonarQube easily picks up these types of resource leaks, especially in Java.

Exactly.

It's very disappointing to see that Uber engineers would rather trust an LLM to that claims to spot these issues when a battle-tested scanner such as SonarQube would have caught this in the first place.

The LLM hype-train is almost just as bad as the JavaScript hype train in the 2010s where some of the worst technologies are used on everything.

rvz2• 1 year ago

Why exactly do you need LLMs for this when efficient alternatives like SonarQube or checkstyle already do this without the expensive waste LLMs create?

This adds little to no technical advantage over existing solutions what so ever for this particular use case.

yahoozoo• 1 year ago

stupid af

Traubenfuchs• 1 year ago

So you tell me those 200-600k software engineers that can easily solve leetcode hard are so incompetent they missed using try-with-resources at such scale, they needed to introduce new AI tooling to fix it?

Hey Uber, I am from the EU, I usually can‘t even solve leetcode medium but I will write you scalable, spotless Java for a third of the salary.

Our industry and its economics are a joke.

hello_moto• 1 year ago

So you write bug-free scalable code 100% in any jobs you ever worked for?

I guess we don’t need QA and Dev/Staging environment

rad_gruchalski2• 1 year ago

Can the QA team? How does the dev/staging environment help writing less buggy code?

rad_gruchalski2• 1 year ago

But can you leetcode heh.

TYMorningCoffee• 1 year ago

A lot of commenters point out that there already are many established static checkers that do this. That is not what Uber attempts here.

Uber is not proposing a static checker. They even use sonar qube in their architecture. They propose using an LLM to resolve the leak detected by sonar qube.

Fixrleak: Fixing Java Resource Leaks with GenAI

Related Stories