PHPAlgorithms – PHP algorithm and data structure library

https://github.com/doganoo/PHPAlgorithms

by dogano • 7 years ago

77 20 7 years ago

ademup• 7 years ago

Hey this is fantastic! I don't care about the job interview part, but having the ability to see some of these algorithms implemented in my daily workhorse may help me improve as a programmer. So thanks!

dogano2• 7 years ago

feel free to use and extend it :)

TekMol• 7 years ago

I think it would be better to publish the individual structures as standalone files without dependencies.

Then I might use one of them in the future.

But pulling in thousands of lines of code by someone from the internet is nothing I would ever do. Because I cannot review it all to be sure it is not malicious. Reviewing a single file without dependencies is something I might do.

simion3142• 7 years ago

It makes more sense you keep only the files you need, I do not understand how exactly the author should bundle this OOP using algorithms in 1 source file that will satisfy everyone requirements and at the same time won't contain some code you won't use.

ainiriand2• 7 years ago

That is kind of what I am doing myself, still learning some concepts so the code is not very reliable but merely educational.

https://github.com/sh4ka/coding-exercises

dpcan• 7 years ago

This makes me feel bad about clicking Install > Activate on all those WordPress plugins every day.

wwweston• 7 years ago

Didn’t we all give up worrying about that with the rise of package managers?

kyriakos• 7 years ago

The problem is that no one reviews what goes in the package registries. Unless someone spots the security issue it goes unnoticed and unfixed. Particularly true with new and not very popular packages.

To be fair to the author though this package won't take more than a couple of hours review quickly for potential back doors and if you just want one data structure it's at most in 3 files.

brokentone3• 7 years ago

This concept of reviewing every line of OSS and copy / pasting the ones you agree with is really holding PHP dev back. Embracing dependency management is an important way to focus your codebase on your application code and is just a modern practice in all languages (https://12factor.net/dependencies). This is part of why JS (particularly node / isomorphic) is continuing to take over previously PHP marketshare. The actual (vs handwavey) security risks are low especially for popular projects.

In this case, if the datastructure or algorithm were useful to your project, you could: 1. Not use the algorithm / data structure at all, resulting in worse performance. 2. Hand roll your own version which is more likely to have improper implementation issues than an OSS version, likely resulting in performance or security issues and wasting your time. 3. Use the OSS version which is likely to have bugs / errors / security issues already solved.

stephenr2• 7 years ago

This concept of not reviewing any libraries you rely on, and installing them from a third party, mutable source is really holding nodejs back.

Embracing reliable development and deployment practices would prevent you from being the butt of the joke next time someone pulls a leftpad, or what have you.

_RPM• 7 years ago

Have you ever heard of Composer?

asnyder• 7 years ago

Maybe I missed something, but you can clearly go into each file in the src folder. I took a quick glance and things seem to be fairly small and separated. You can always just take the class/method you want without taking all the files, or package.

Not associated with the project, but confused as to the follow-up threads.

simonhamp• 7 years ago

Says the person still chipping away at his own still-square version of the wheel.

dogano2• 7 years ago

Hey,

there is much more than just providing OS source code. I personally think that single files are going to be overkill and the "review" will not happen because it will be too much.

On the other side, the source code is on GitHub. You (and many other developer) are welcome to review. GitHub would not allow malicious code to be hosted on their platform. And in the end, it is the same process as you would review single files..

Further, there is also the aspect of dependencies: the power of OS software provides the ability to use other OS libraries. This means that I do not need to reinvent the wheel and use existing solutions. Providing single files would require that you make a bunch of 'include' statements before you can run my code. This is pain..

And finally, I - as the creator - guarantee that PHPAlgorithms does not do malicious things :)

PHPAlgorithms – PHP algorithm and data structure library

Related Stories