Golang on GitHub

220 106 12 years ago

It's unfortunate that it isn't possible to disable pull requests. There is already noise appearing there, which will always be a wart so long as pull requests can't be disabled.

ishityounot2• 12 years ago

Noise? That's how contributions are called now?

colinramsay2• 12 years ago

No, it's just that the Go team have decided to continue with their current contribution process rather than using pull requests. I don't know whether this is a permanent decision or not.

"The Go team will not be accepting pull-requests here. Contributions must still go through the normal code-review process and gerrit. The updated contribution steps are not yet available though."

https://github.com/golang/go/pull/9219

iand• 12 years ago

Yes, when they are on a mirror of a code repo. The upstream repo is at https://go.googlesource.com/go

nemothekid4• 12 years ago

Go already has an established contributing process, and people who make PRs without bothering to understand that process are likely just making noise.

masklinn4• 12 years ago

Github PRs are noise when the contribution workflow does not use PRs.

Go's contribution workflow does not use PRs.

ivank• 12 years ago

I've seen projects solve this problem by keeping a pull request open that indicates where contributions should go instead.

jbrooksuk• 12 years ago

That still doesn't prevent people blindly creating a new pull request though.

farresito2• 12 years ago

This is the gerrit link, I believe: https://go-review.googlesource.com

dsymonds6• 12 years ago

This was announced in mid November: https://groups.google.com/d/topic/golang-dev/sckirqOWepg/dis...

To be clear, Go is not "on" GitHub except for its issue tracker and wiki. The code is being developed, reviewed and submitted on https://go.googlesource.com, using similar infrastructure to Android and Chromium.

Xeoncross• 12 years ago

So, that c/go code I see in the repository isn't actual code or...?

pluma• 12 years ago

It's a mirror, as I understand it.

nemothekid4• 12 years ago

Its actually pretty cool that all the google code issues got turned GitHub issues, in the same exact order as the google code issues such that the issues numbers are still consistent on Github.

blowski• 12 years ago

I'm guessing they did it with an import script - something like http://www.iqandreas.com/github-issues-import/configuration/...

giovannibajo1• 12 years ago

I went through a similar migration last month for PyInstaller, and we couldn't find a way to set the original date for issues/comments; the best solution was to add the date/time as part of the comment; see just one example here: https://github.com/pyinstaller/pyinstaller/issues/830

The script you linked does the same (we used a different now). We even contacted GitHub and they said we were out of luck, very sorry.

Now, I see golang has perfectly migrated all the timestamps. I wonder how they did that. If they used some private APIs, I would be very annoyed with GitHub support.

Spiritus• 12 years ago

I'm getting 404, has it been removed?

dsymonds6• 12 years ago

Unfortunately a significant problem was just found in the process for migrating the issues from code.google.com to GitHub. We're going to re-do the migration, but need to lock down the repo so we don't blow away anything that someone might enter.

It should be back soon-ish.

krzrak• 12 years ago

...aaaand it's gone

bhaavan• 12 years ago

If you go to that link you might get 404. You can go to https://github.com/golang/ to explore. Once you go there, you might see go as a project too.

Go overuse is purely intended.

shawnps4• 12 years ago

Did anyone do anything special to get their contributions attributed to their GitHub account? Mine are not showing up here: https://github.com/golang/go/graphs/contributors

masklinn4• 12 years ago

Do you have the mail address you used for your contribution in the set of github email addresses? (https://github.com/settings/emails)

shawnps4• 12 years ago

Just added it now, perhaps it will update. I'll check back on it later, thanks.

dsymonds6• 12 years ago

See https://help.github.com/articles/why-are-my-contributions-no....

The most likely reasons are:

  - your email address used for your Go contribution is not associated with your GitHub account
  - your contribution is over a year old
  - you haven't starred the project

shawnps4• 12 years ago

Interesting, I'll star the project and see what happens. I see other people's contributions showing up that are over 1 year old so I'm not sure if that is why.

W0lf2• 12 years ago

Did someone else notice the c joke (?) in the first 3-4 commits?

bbrazil• 12 years ago

https://github.com/golang/go/commit/7d7c6a97f815e9279d08cfae... https://github.com/golang/go/commit/0bb0b61d6a85b2a1a33dcbc4... https://github.com/golang/go/commit/0744ac969119db8a0ad32539... https://github.com/golang/go/commit/d82b11e4a46307f1f1415024...

saljam• 12 years ago

R=dmr

RIP Dennis.

prezjordan• 12 years ago

So these are actually commits from the C language? Or are they spoofed?

Obviously there wasn't Git back then, but did they use some sort of version control when developing C?

sanxiyn3• 12 years ago

Unfortunately, this joke makes GitHub Graphs page much less useful, because graphs start from 1972.

https://github.com/golang/go/graphs/contributors

Is there a way to get this fixed?

Cederfjard• 12 years ago

It's not that big a deal, is it? You can just narrow the span down like this: http://cl.ly/image/3A12032B3Q2O

W0lf2• 12 years ago

You can select a timeframe like this: https://github.com/golang/go/graphs/contributors?from=2008-0...

dsymonds6• 12 years ago

You could file a bug against GitHub.

Maybe they could also fix their recognition of email addresses to permit `<research!bwk>` too.

joeblau• 12 years ago

Hah, that's funny. Give credit where credit is due.

LunaSea• 12 years ago

How come the number of issues is that high ?

copx• 12 years ago

The number is not that high at all. I only see 1,289 open issues. To compare the D issue tracker has 3,677 open issues right now and the D user and developer community is tiny compared to the Go community.

Also note that "issue" does not necessary mean "bug". Such trackers are also used to request features just like in this case. Many of the D and Go "issues" are actually feature requests.

dsymonds6• 12 years ago

It's been a very active open source project for over five years. It's roughly 5 issues per week.

sanxiyn3• 12 years ago

Rust has 2,163 issues at the moment, compared to Go's 1,289.

sanxiyn3• 12 years ago

I find it interesting that Rust has a lot more contributors compared to Go. Comparing https://github.com/golang/go and https://github.com/rust-lang/rust, all contributors: 380 vs 695, contributors with more than 100 commits: 17 vs 35.

fhs• 12 years ago

Keep in mind that contributing to Go requires that you sign a contributor license agreement, something people might not want to go through (no pun intended) for small changes.

baldfat2• 12 years ago

BUT this allows for easier changing of the licensing.

untothebreach• 12 years ago

I believe Rust requires a CLA as well. Might be wrong, but I seem to remember getting a mail about that a while back. A rust dev that knows for sure can correct me, if necessary.

farslan2• 12 years ago

Also contributors are not the same as committers in Github. And I've found that Github doesn't display Authors but only Committers. Example: https://github.com/golang/tools/commits/master/cmd/cover/fun...

masklinn4• 12 years ago

Github does display both author and committer, and has for some time. If an author is present, it's the contributor.

barosl• 12 years ago

One thing I love in Rust is that it purely makes use of the existing infrastructure that everybody knows - GitHub.

Every Google project uses its own repository, issue tracker, and mailing list. Even many Mozilla projects such as SpiderMonkey require some knowledge to access their infrastructure. However, almost all development in Rust are done only using GitHub. No external dependencies. One exception that is not part of GitHub would be the build bot, though it doesn't matter much.

I know that GitHub centralization is not a good sign, but Rust's all-in-one approach really lowers the barrier to entry significantly.

Gankro• 12 years ago

Buildbot and Bors are also hosted on Github. :D

https://github.com/rust-lang/rust-buildbot https://github.com/graydon/bors/tree/rust

shurcooL2• 12 years ago

I've made several CLs like this commit [1], yet I am not seeing myself listed under contributors.

[1] https://github.com/golang/go/commit/912ec1990bd09f8fc128c3fa...

dbaupp• 12 years ago

I believe the .../graphs/contributors page only shows the top 100 contributors (for Go it looks like the threshold for commits is approximately 6).

azatris2• 12 years ago

I'd like to mention that for me personally the biggest issues with the language so far is its unappealing name.

'Go' sounds like a bad sports drink.

Does anyone think the same?

Is it for the greater good to be inviting for more pragmatic thinkers (instead of people who care about aesthetics)?

valarauca1• 12 years ago

To me "Go" is associated with the game Go/Baduk.

Which happens to be a amazing game not only for abstract thinkers, but for aesthetic beauty.

psaintla• 12 years ago

If you choose your tools based on the naming you're going to have very few left to work with.

snowwrestler2• 12 years ago

I don't use Java because I'm more of a tea drinker.

azatris2• 12 years ago

Thanks guys, the amount of negative votes lets me know I should change my perception of it, because I'm likely the minority. I thought this is an issue if we want to invest in the future of a language, but apparently it isn't.

comex2• 12 years ago

Hmm - how did they manage to backdate the issue/issue comment creation? I don't see it in the GitHub API documentation.

bradfitz• 12 years ago

Special process, working with support@github.com. They have an internal tool that will migrate a special format (which we had to prepare). After 14 tries, we got it right. Mostly. We still couldn't do lots of things we wanted, but it was way better than our first version where we did it all via API calls.

comex2• 12 years ago

A (much smaller) project I contribute to might want to similarly migrate issues from Google Code to GitHub. It would be nice if backdating were available via a standard API, but I guess it's not terribly important for us. A bigger problem is that we'd like issue numbers to have a 1:1 mapping, but we're already using GitHub for pull requests, and pull requests are issues, so something would have to give... however, if we could specify arbitrary (unused) IDs, we could do something like add 100000 to the old issue numbers. Just thinking out loud.

Golang on GitHub

Related Stories