1-Click GitHub Token Stealing via a VSCode Bug

https://blog.ammaraskar.com/github-token-stealing/

by ammar2 • 2 months ago

660 101 2 months ago

blog.ammaraskar.com

Noumenon72• 2 months ago

Thank you for essentially donating the time you spent on this exploit to raise awareness on improving VS Code's security response. You could have just given up on them but you're still trying to help.

ammar29• 2 months ago

Thank you, that's a very kind comment.

I have no interest in selling these vulnerabilities or sitting on them. At the same time, it feels really bad to have a vendor disrespect the hours it can take to make a proof-of-concept by just patching it silently and not crediting you or acknowledging it.

zbentley3• 2 months ago

This is a very good writeup.

Zooming way out (perhaps to the point of useless observation), it's a pity that the web embedded VSCode editor is signed into GitHub at all. Defense-in-depth or not, a huge vulnerability surface arises from that original sin. It'd be like if you had a god-permissioned GitHub API token stored in world-readable plaintext on your workstation for the malicious-NPM-package-of-the-week to find.

In a perfect world, it'd be awesome if the in-browser IDE launched with a temporary per-repo permission scope or token that allowed only pull and push to the repo in question; no github.com web session whatsoever. If you want the full GitHub web UI experience, well .... go back to github.com; make github.dev a single-repo service.

I'm assuming that's a) inconvenient for users, b) hard to implement, and c) a historical assumption baked into a lot of the github.dev tooling, though. Ah well.

owl57• 2 months ago

If the malicious-npm-package-of-the-week is reading arbitrary files on your workstation, isn't it usually able to run git clone/push/whatever with your current credentials anyway?

digi59404• 2 months ago

Yes, but also no. For example in GitLab a user who’s infected could push code to a branch. Then it could even make a merge request to pull that branch into main (if main is protected).

But then someone else on the team should have to manually approve that MR to allow it to be merged to main.

This kind of defeats the ability of malware to push stuff out automatically.

ikiris• 2 months ago

Not if they're touch required in a secure enclave like a yubikey

ammar29• 2 months ago

it'd be awesome if the in-browser IDE launched with a temporary per-repo permission scope

That's actually exactly what they do for codespaces. The token only has read/write on the repo you activated for the codespace [1]. They should definitely consider doing that for github.dev as well.

[1] https://orca.security/resources/blog/hacking-github-codespac...

itopaloglu83• 2 months ago

Or they could’ve kept their bounty program running smoothly. But instead they pissed off another security researcher and received a zero days heads-up before public disclosure.

amluto2• 2 months ago

temporary per-repo permission scope or token that allowed only pull and push to the repo in question

How about pull from the repo but only push to a staging area from which the user, but not the token, can push for real?

Frankly, LLM agents should do this too. Letting your LLM push seems foolhardy to me.

moi23882• 2 months ago

That makes so much more sense.

alostpuppy• 2 months ago

Exe.dev has an integrations feature which is similar allowing you to grant access to specific repos without having give the VMs credentials. I think it’s a similar pattern to iron.sh.

I have been thinking more and more about how I might use this pattern.

namibj• 2 months ago

Jules is heavily restricted in what it can do to your repos.

lifis2• 2 months ago

You can just fork the repository, give it access to the fork and then merge what you want

ndegwaduncan• 2 months ago

the scope problem is actually worse with agents than with github.dev. the architectural answer is the same though: the credential the agent operates with should be scoped to the task and expire when the task ends.

ffemac3• 2 months ago

malicious-NPM-package-of-the-week

This is going to get worse and worse. I recently noticed AI harness (e.g. OpenCode) downloading random npm packages in the background and litter them everywhere in a few place in ~ and in your project dir, all without telling/asking you.

What's worse is that people don't seem to care even the devs.

himata41132• 2 months ago

You typically don't want to run opencode outside a sandbox anyway.

lifis2• 2 months ago

I think it's ok to be signed-in when opening your own repositories, but definitely not when opening repositories from other accounts. And also the webview keyboard shortcut thing needs to be fixed to only allow harmless keybinds and NOT propagate to any keydown handler. Also on desktop it should be removed in favor of Electron intercepting directly. And on web it should probably disabled by the default.

hju22_-3• 2 months ago

You can use SSH keys and GitHub deploy keys to approximate this. Can't speak for the security of it, but I have never set up GitHub with access to every repo. Not sure if there exists approximate functionality in other git forges though.

zbentley3• 2 months ago

How does this work with the in-browser editor at github.dev?

maxloh• 2 months ago

I think the problem lies in the fundamental design of VS Code extensions in general. They are essentially Node.js apps with full access to built-in modules, including fs. If the corresponding VS Code instance is launched with your user privileges, extensions can technically read files in ~/.ssh.

It is not safe in the sense that for every extension you install, you are essentially installing a new Node.js app with all its bundled dependencies. Even if you trust the publisher, I am sure there are many holes to exploit.

zbentley3• 2 months ago

My comment had more to do with the in-browser VS Code instance. Regardless of the extension security model, having the github.dev webapp run under your full github.com account's permissions significantly expands the attack surface: if you launch github.dev in one repo and install a malicious extension, that extension can reach and compromise all repos your GitHub user can reach, private or public. Scoping it to one repo would only allow a malicious extension to write code in that repo and not mess with the GitHub API or other repos.

Separately, I think the debate around extensions/plugins in general boils down to the same conversation about trust and isolation we have for every third-party software supplier (package managers etc.).

Options include:

1. Vetting/blessing certain extensions.

2. Serving built extensions from a central registry/artifact store with security protections

3. Having VSCode organically grow a shitty version of different operating systems' "X wants to access Y; confirm?" permissions access system (a pain in the ass to do in a cross-platform way).

4. Having VSCode somehow run extensions as separate applications according to the OS and leveraging the OS's permission system (still hard, and because it's an IDE, rather a lot of extensions will need--or request because of sloppy extension code--very broad permissions, at which point an extension is one transitive dependency update away from compromising your system).

5. Running the entire VSCode instance in some sort of container/VM/sandbox (the amount of access holes folks poke in the Snap/Flatpak VSCode instances, and the number of common issues for which "stop using the container and install VSCode directly on the system" is the recommended fix does not give me hope that this will be adopted by anyone but the most expert, patient, and paranoid users).

paulddraper• 2 months ago

It'd be like if you had a god-permissioned GitHub API token stored in world-readable plaintext on your workstation for the malicious-NPM-package-of-the-week to find.

That's...exactly what the AWS CLI does.

fg137• 2 months ago

To those folks, I am sorry, but this is one of the few levers I have to try to influence MSRC and the security posture of VSCode

Someone is going to be blacklisted by Microsoft.

ares623• 2 months ago

"Oh great Mythos, how do I remove all vulnerabilities from my products?"

Percolating...

Ban all vulnerability researchers

theguidessuck2• 2 months ago

Damn, what a disaster. Then they won't allow him to tell them about the bugs they don't take seriously.

NagatoYuzuru• 2 months ago

the last time I interacted with MSRC regarding reporting a VSCode bug, it was a horrible experience where they silently fixed the bug

Classic MSRC. It has figured out that researchers will report for free regardless. Why change?

natpalmer17762• 2 months ago

It was the status quo for a long time, then the pesky security researchers started asking for compensation instead of clout.

ammar29• 2 months ago

instead of clout

I'm catching up on the infosec twitter side but it seems like it was even worse. A lot of people have the same story as me in 2023 of "they silently patch the bug and don't even credit you" which really stinks.

opello• 2 months ago

Do it for the exposure! Artists of many stripes have had to combat that for ages.

guessmyname• 2 months ago

MSRC doesn’t fix bugs.

I don’t know the specifics of this case, but I’ve managed bug bounty programs in the past through Bountysource and HackerOne. One thing that occasionally happens is that a report makes its way to the development team before the security team has fully assessed it, in this case MSRC.

At that point, a developer may decide to quietly fix the issue. Sometimes that’s driven by a concern, rational or not, that being associated with a security bug could reflect poorly on them or affect future promotion opportunities. The result is that by the time the security team attempts to reproduce the report, the vulnerability is already gone.

From MSRC’s perspective, all they see is that the provided reproduction steps no longer work. They have no visibility into the internal history of the bug or whether someone already patched it. As a result, the report gets closed as invalid even though the original finding may have been legitimate.

anonbanana• 2 months ago

That makes sense but doesn't excuse the behavior. Just because there is poor communication within Microsoft doesn't make it okay to silently patch a vulnerability. Also, looking at the timeline on OP's post from 2023 it seems they patched it and closed the bug on the same day which is a little sus .

moi23882• 2 months ago

Nonsense. As if there are no versions for their software releases.

This is laziness, security absolutely could verify these steps.

peterkelly• 2 months ago

If only there were some kind of system for recording the version history and viewing what changes had been made to the code between releases.

theguidessuck2• 2 months ago

They have no visibility into the internal history of the bug or whether someone already patched it.

Aww man, if only they owned some sort of platform for tracking those, powered by some sort of program. Doesn't even have to be a smart problem, it can be, succintly, shortly, stupid. If only.

hilariously• 2 months ago

Your post reads like "This doesn't happen, except when it happens and the person has no recourse and it does in fact happen." - why make the post at all? If your internal workings fuck over someone externally prepare for your department to take the blame even if its "not your fault" - you work at the company that just fucked them over.

celiacFun• 2 months ago

This is complete nonsense. Windows releases are supported for 10+ years. Security bugs are patched in all releases that are impacted regardless of whether the issue exists in current branch. A developer fixing an issue has no impact on MSRC being able to reproduce the issue on released builds. The existence of security bugs does not reflect poorly on individual developers, most of whom maintain code they did not write.

pier25• 2 months ago

The MSRC situation is really unbelievable.

There are probably better sources but I think this video by The Primeagen is a good introduction.

https://www.youtube.com/watch?v=9kxx5xp5nTQ

october8140• 2 months ago

If you like VSCode but don't like Microsoft, try Zed (zed.dev).

ZeroCool2u• 2 months ago

Zed is excellent. I know it's weird, but the last thing holding me back is being able to have a browser based Zed session the same as VSCode.

Quothling• 2 months ago

I heard that Zed came with a lot of integrated AI and team sharing features that phone home, so that's an issue for anyone working with stuff like NIS2 compliance. Not that VSCode isn't a compliance nightmare as well.

dddw• 2 months ago

If you like vs. but not M$. Use VsCodium. I did, but now preffer zed, which replaced my use of vscodium and sublimetext in 1 swoop.

arianvanp• 2 months ago

Zed downloads random binaries on startup without any permissions prompts. No thanks.

ffemac3• 2 months ago

I looked into Zed because popular harness (OpenCode/KiloCode) just random downloads npm packages in the background and didn't tell you. But then I found out reports of Zed doing the same. Why we can't have nice things?

throwaway041207• 2 months ago

Zed is nice, but the project wide search (sidebar based) in VS Code and diff viewer in VS Code are still better IMO and unfortunately since I no longer code, those are my most used features of an editor. Still using it instead of VS Code but I sure wish it improved those views.

karimf• 2 months ago

I've been using Zed for a few weeks now and these two are also my main complaints as well.

thrdbndndn• 2 months ago

Very good write up but I lost it a little at the end. Could someone clarify for me?

The author said:

You cannot just use the shortcut trick to install the evil extension directly because of new publisher trust system;

You can bypass this by using local workspace extensions which has no publisher screening, but CSP blocks it;

The solution seems to be that installing a local workspace extension which binds a shortcut of 'install extension without checking publisher'.

So I assume it means:

1. you need two extensions, 1st one is local and only for the keybinding, and 2nd one is the 'real' evil one and it doesn't need to (actually can't, because of CSP) be local anymore?

2. the CSP only prevents the JS in local extension but nothing about its package.json (or the ability to add shortcuts), right?

ammar29• 2 months ago

1 and 2 are correct, take a look at the PoC repo here: https://github.com/ammaraskar/github-dev-token-steal-poc/tre...

We can try to just put a `my-extension/extension.js` for the most direct execution but the CSP blocks that. It's only a script-src CSP blocking it though, so fetching the package.json is still kosher. So we end up using it to contribute a keybinding instead.

zuzululu5• 2 months ago

I had this happen to me recently

github token got stolen and also cloudflare tokens

guys even if you take security seriously you are going to get hit on a long enough time frame

best thing to do is segregate and control damage

trust no one, nothing, use orbstack, and always operate under the assumption that your token is going to get leaked at some point

it knocked off my entire momentum. fortunately seemed like it was just a spam bot that took my tokens and created bunch of fake spam pages and trying to mine crypto

the biggest feeling is the one of feeling violated

take care fellow travelers

pjot• 2 months ago

  > created bunch of fake spam pages and trying to mine crypto

Pages like GitHub pages? We’re repos being created in your account? Curious how you discovered that your tokens were pwned

zuzululu5• 2 months ago

repos created, cloudflare eployed thee websites, edited dns

saw a weird spam site, so damn tired went to bed thinking it was some mislick on my side

woke up next morning and loaded up my domain, it redirected and panic set in

my SEO is probably nuked even though it has been under 24 hours

worldsavior2• 2 months ago

Secret ad to orbstack.

zuzululu5• 2 months ago

first time I mentioned it on here and no it won't be enough but better than running npms from wild naked

just pointing out what I use currently if you know something better/competitor please feel free to advertise them

rbobby• 2 months ago

best thing to do is segregate and control damage

I first encountered that concept with a client that put every webapp in it's own virtual server and expected the vm to get compromised at some point. Seemed like a very sensible idea 15 years ago.

zuzululu5• 2 months ago

my point was to limit access to tokens, segregate with different accounts for different apps, different computers or ISP if need be.

wall it off and dont trust VMs either. if you have something of value they can escape it.

antimony51• 2 months ago

if you had some other XSS in a webview that you can get a victim to open, you get effectively full RCE on their computer.

Github creds or the computer, can't decide which one is worse.

selectively• 2 months ago

Very unethical behavior combined by very bad security posture from the vendor. Bad.

ThanosAkr2• 2 months ago

I am a bit confused. What if I just revoked OAuth access to github.dev? Wouldn't that just make the token unusable?

ammar29• 2 months ago

You cannot, it doesn't go through the regular OAuth flow. GitHub just automatically grants it a token.

ThanosAkr2• 2 months ago

Oh, i see thanks for the reply.

meszmate• 2 months ago

I don’t really understand why more devs don’t try Neovim.

Maybe it’s just my preference, but I like having a small setup where I know what is installed and what is running. With VSCode, browser IDEs, extensions, sync, tokens, and random plugins, it gets hard to tell what actually has access to what.

shinycode• 2 months ago

I noticed that is quite hard to make people change habits regarding software. There is shortcuts to learn and we might feel slow at first which reinforces the feeling of « it’s not better ». It takes a while to get used to nvim, once there it’s faster but that explain why many people stay in their confort zone

okayishdefaults• 2 months ago

One of the most important things I've ever read as someone that wants to be able to break out of my comfort zone was from Uiua's website. Foreign != confusing

ulimn• 2 months ago

I really like Helix. I didn't dig into Neovim much but Helix has pretty nice IDE-like features that I always missed from vim (without riddling it with plugins or using SpaceVim or such). Check it out, maybe you'll like it as well.

strogonoff• 2 months ago

I stopped using VS Code and switched to Neovim some years ago, once I noticed that the former would automatically install random Python packages with typings for libraries without stock typings. The “feature” (part of Microsoft’s official Python extension, which was the only one that worked acceptably well for me in other regards) ended up installing type definitions for a different version of a library than the one my project would use, seemed wildly insecure as it casually ran third-party unvetted code, and was evidently not configurable.

I wish I could add “and I never looked back”, but honestly in the past year or two Neovim started regularly breaking my setup (approximately every upgrade). Had some inklings it might happen eventually… Strictly speaking, 10 years in, nvim is yet to have its first stable version released—which means technically one can’t blame it for instability, but which is useful to keep in mind.

Considering going back to plain vim. I’m sure I will lose many niceties, but hopefully it would not require me to troubleshoot broken functionality in the middle of work.

mplanchard• 2 months ago

Emacs with vim bindings (evil mode) is also pretty great, and about as stable as it gets. I’ve been all-in for I think 6 or 7 years now. I just the other day installed a little package for tyographic quotes that hadn’t been updated in 16 years (!!), and it worked great.

Depending on what third party packages you use, you may sometimes get breakage there, but if you start out with a kit like doom emacs, you’ll be largely insulated from that.

There’s also always newer stuff like zed, which looks pretty great and is very snappy in my limited testing.

omelas_tech• 2 months ago

tl;dr: never press github.dev or open vscode.dev on a repo you don't trust

minitech• 2 months ago

and don’t open links like https://tinyurl.com/2s3twstw either, or any other page on the internet that’s able to redirect you to github.dev

simonw• 2 months ago

That's a hard rule to follow when any website on the internet might redirect a browser tab to a URL on one of those domains.

parable• 2 months ago

Kudos for the public disclosure. Too many people haven't been happy with MSRC and it's starting to boil over (see the Nightmare Eclipse situation, too). Maybe all of these disclosures will cause them to do some introspection and realize they're the problem. I highly doubt that, but one can dream.

nicce2• 2 months ago

I am not sure if this is still the best approach. They did not even try to submit based on expected "low" ranking when comparing to existing XSS submission. They should at least try or let them know many days before disclosing. You never know.

jeremyjh• 2 months ago

Its not just one issue they mishandled. It is a pattern. I think this makes sense if you believe long-term security requires leadership change at MSRC.

https://doublepulsar.com/microsofts-stance-on-zero-day-explo...

ammar29• 2 months ago

It's not just based on that, if you read the linked report from 2023 (https://blog.ammaraskar.com/vscode-rce/), I had a bug with the exact same impact of token exfiltration (It did need one additional click on the VSCode interface). They marked it as low severity, fixed it silently, didn't acknowledge that it had security impact and did not provide me any credit much less a bounty.

AgentReinAi• 2 months ago

The attack surface that makes this particularly nasty is that VSCode extensions run with the same trust level as the editor itself, and most developers have dozens installed without reviewing their permissions. A malicious or compromised extension silently exfiltrating GitHub tokens is undetectable without network monitoring. This is a good argument for running extensions in isolated profiles.

crimsonnoodle58• 2 months ago

is undetectable without network monitoring

Even with network monitoring, exfil to Github itself can be very hard to stop unless you SSL intercept and have very strict URL allow lists.

Best is to move away from Github, move to self hosted internal Gitlab/Forgejo and block Github completely.

imron• 2 months ago

I love vanilla vim.

JessieJanie• 2 months ago

Thank you for all your efforts and detail here, noted.

notlibrary• 2 months ago

And when what it does with it?

NoahZuniga• 2 months ago

The only way to allow this behavior is to have the two web pages in the different origins cooperate with each other using the Window.postMessage() API

Small nitpick, but it's also possible to communicate by changing the location.anchor property (by either the iframe or its parent window.)

Webhix• 2 months ago

This is a very good writeup.

delis-thumbs-7e• 2 months ago

Ok, I really need to look into Kate and maybe Neovim. Fuck this shit, honestly.

jonnyysmith• 2 months ago

GitHub does not currently provide a built-in repository setting to disable github.dev

Very cool.

ammar29• 2 months ago

Update as of 3rd June: Microsoft has fixed this with a stopgap fix by adding a confirmation when opening notebooks in web VSCode and not allowing trusted publisher to be skipped by commands (https://github.com/microsoft/vscode/pull/319705).

That's probably one of the fastest responses I've seen from a vendor.

EMM_386• 2 months ago

This is an excellent and very interesting write-up.

It's so refreshing to read technical articles that are clearly written by a knowledgeable human and explained perfectly like this. By walking the reader through this with the example screenshots it unfolds and gets more interesting as you continue reading.

It's also strange to realize that these days, most articles are not like this.

ammar29• 2 months ago

heh, a friend actually pointed out a typo on a first draft and said "maybe you shouldn't fix it to show it's not LLM written".

lionkor• 2 months ago

I understand that there's frustration with MSRC, but surely the right move is to keep doing things right to the best of your abilities.

Like, disclose it, wait a week, publish it. That seems, to me, like it would avoid almost all the bad press this is getting, and shows that the researcher DOES care about actual security and not just recognition from MSFT.

insanitybit• 2 months ago

It's up to the researcher to make the call. Maybe they feel that it's best to disclose to bring attention to the MSRC problem - arguably, that'll be massively better for security longer term vs a point in time vuln disclosure.

warm_soup• 2 months ago

Excellent write up explaining all the steps with screenshots. It must have taken significant time to do this POC.

sandeepkd• 2 months ago

The more I think about it, I feel sad about this state of things. More than likely chances are that there are people in Github who already knew about this behavior, unfortunately raising issues can be seen as introducing more friction to product/feature and it certainly does not puts anyone in good light so they either kept quiet or the more vocal voices drowned them.

cyh555• 2 months ago

the title should be changed to '1-Click GitHub Token Stealing via a VSCode Bug in the websites vscode.dev and github.dev* only'

1-Click GitHub Token Stealing via a VSCode Bug

Related Stories