Claiming Bitcoin's Bug Bounty

http://hackingdistributed.com/2013/11/27/bitcoin-leveldb/

by hendzen • 13 years ago

74 8 13 years ago

Aqueous3• 13 years ago

Has it been verified that the bug is fixed as in no further database corruption? I'm confused what you mean by this "sample" you got from Gavin.

MBCook• 13 years ago

I assume he meant one of the log/database files that contains the corruption.

Aqueous3• 13 years ago

That's what I initially thought, but then I missed the part where they've confirmed that this fixes the bug. Has this been tested?

rescrv• 13 years ago

Gavin posted a link to some corrupt LevelDB instances here: https://github.com/bitcoin/bitcoin/issues/2770 He also sent the same link to me via email.

I took a look at them, and figured out what in the write path could have gone wrong to create the bad behavior. It turned out to be in db/log_writer.cc and deps.

I cannot promise there are no other bugs within Bitcoin or LevelDB, but this resolves one issue. I'm interested in seeing it tested in the wide area, just to make sure.

Of course, if there are other bugs, I'm just as happy to debug and squash them.

ers35• 13 years ago

The Darwin man page for munmap has more detail: https://developer.apple.com/library/mac/documentation/Darwin... See DIRTY PAGE HANDLING.

  If the mapping maps data from a file (MAP_SHARED), then the memory will eventually be written back to disk if it's dirty.  This will happen automatically at some point in the future (implementation dependent).

The XNU source may be useful: http://fxr.watson.org/fxr/ident?v=xnu-2050.18.24&im=excerpts...

kristianp• 13 years ago

Does this mean it's a bug in Darwin?

Claiming Bitcoin's Bug Bounty

Related Stories