Copy-paste broken on WhatsApp on Firefox

https://github.com/webcompat/web-bugs/issues/125920

by arch1e • 3 years ago

2 1 3 years ago

rolph• 3 years ago

> Egrodo commented Aug 17, 2023 •

Thanks for the report! I confirmed that this is a recent regression and spent an afternoon looking into it. The fix has landed and should be deployed on Monday :)

This was an interesting bug so I figured I'd explain the fix below for anyone interested:

the issue boiled down to an async wrapper we had over the DataTransfer constructor that we were using to check osme other things before handling the DT. We were doing something like:

const data = event.clipboardData;

let text = data.getData(MIMETYPE_1); await SomePromise(); if (text == null) { text = data.getData(MIMETYPE_2); } ...

In this case MIMETYPE_1 was set when copying things from within WAWeb, and MIMETYPE_2 was text/plain, so basically any text copied from outside the app fell into this.

The issue was that by calling await we were switching into a different callstack, thus (presumably) triggering Firefox's more aggressive garbage collection to forget the contents of the data object. So when it came to calling data.getData the second time, the contents of the data object were missing, and we'd overwrite text with nullish. This is unintuitive since we didn't switch lexical scopes, but I suppose Firefox considers DataTransfer objects more expensive than other browsers?

The fix was to run both checks at the same time before calling any async code so the data would be preserved:

Aka:

const data = event.clipboardData;

let textOne = data.getData(MIMETYPE_1); let textTwo = data.getData(MIMETYPE_2); await SomePromise(); let text = textOne; if (text == null) { text = textTwo; } ... <<

Copy-paste broken on WhatsApp on Firefox

Related Stories