Move all photos from Google takeout into one directory

https://gist.github.com/ljahier/0fc9f7f0f4a239b7d07bed875abd34d7

by ljahier • 4 years ago

37 22 4 years ago

gist.github.com

sdfhbdf• 4 years ago

Hmm. You could really benefit from a couple of Linux commands that have “built in concurrency” for such use cases.

I think you could achieve the same result with just the find command:

`find ./takeout -iname “.jpg” -exec mv {} newdir`

dmitrygr2• 4 years ago

.js ? FFS, really?

    find takeout -name ".jpg" -exec mv {} dest_dir

anaganisk3• 4 years ago

What’s wrong with a js script if author is comfortable with it? Is it a rule that everyone must know linux commands?

dmitrygr2• 4 years ago

What’s wrong with a js script

Not much more than is wrong with sending a nuclear-powered aircraft carrier to kill a mosquito

Is it a rule that everyone must know linux commands?

Unix, and yes. Every system around you is built on it or something derived from it (either literally or in design).

kfrzcode2• 4 years ago

Yes, rules 8 and 14

jcutrell• 4 years ago

There is nothing wrong with it per se, and no, you don’t have to know Linux commands to get by.

Sure, a Linux one liner might be “easier” to someone who knows Linux… but that doesn’t mean it’s “wrong.”

ljahier3• 4 years ago

Here the author, I'm not working on windows but macos. I know, the script is not recursive but it's not the goal. The directory architecture of Google takeout > Google photos is one directory per day when there are pictures. In this directory, there are no other directory so the recursive is useless.

The goal was to make a script in quick time and I'm comfortable with nodejs that's why I chose it.

justsomehnguy2• 4 years ago

    ls -Recurse -Filter *.jpg | mv dest_dir

johntash• 4 years ago

Out of everything in this thread, this was the most interesting to me. I didn't know you could pipe a list of files to mv. It makes sense, I guess I just never tried it because anything I would have used it for, I would have used find or xargs instead.

russellbeattie2• 4 years ago

If you're using Windows, then I'd probably just use a script like this as well instead of trying to figure out whatever the equivalent of find is.

If you're not using Windows, you should probably learn to use some basic shell commands.

Also, line 19 has a bug.

Also, readdir('foo', {withFileTypes: true}) will return a list of directory entries so you can check the type without doing a stat. Also, sync versions are easier.

    fs.readdirSync(DOCS_DIR, {withFileTypes: true}).forEach((file) => {
        if(file.name.startsWith('.') || !file.isDirectory()){ return; }
        ...
    });

Symbiote• 4 years ago

Zsh:

  mkdir photos
  mv -v **/*.jpg **/*.mp4 photos

Bash:

  shopt -s globstar
  mkdir photos
  mv -v **/*.jpg **/*.mp4 photos

But I think I'd prefer them in a directory based on the EXIF date in the photo anyway:

Zsh:

  for i in **/*.jpg; do
    date=$(exif $i --machine-readable --tag=0x9003 | head -c 10 | tr : -)
    if [[ -n $date ]]; then
      mkdir -p $date
      mv -v $i $date
    else
      mkdir -p Unknown
      mv -v $i Unknown
      # (Check other EXIF values, e.g. DateTimeOriginal.)
    fi
  done

pjc50• 4 years ago

Note: if you dump all your photos in one directory, prepare for opening that directory to be extremely slow.

russellbeattie2• 4 years ago

Thinking about this later, I realized that this script isn't even recursive. I think we've been Tom Sawyered, but I couldn't resist. I grabbed a Takeout zip I had hanging around and wrote this:

    import fs from 'fs';
    import path from 'path';

    copyMedia('Takeout');

    function copyMedia(dir) {
      fs.readdirSync(dir, {withFileTypes: true}).forEach((file) => {
        if (file.isDirectory()) {
          copyMedia(path.join(dir, file.name));
        } else {
          if (file.name.toLowerCase().endsWith('.jpg') || file.name.toLowerCase().endsWith('.mp4')) {
            fs.cpSync(path.join(dir, file.name), path.join('photos', file.name));
          }
        }
      });
    }

It uses copy instead of move, but it's fine.

Tempest1981• 4 years ago

Are the takeout filenames unique?

I think most cameras get to IMG_9999 and cycle back to IMG_0000

ljahier3• 4 years ago

I only had a few thousand photos so I didn't get into this case. I modified to put in addition the name of the folder which is the date in the filename.

codesink• 4 years ago

I can't believe this is getting upvotes on HN, this is buggy and a simple oneliner can do it.

ljahier3• 4 years ago

I didn't pretend to make a perfect code but just a functional code, and I share it because it can maybe help people who would encounter the same problem as me.

toomuchtodo• 4 years ago

Don’t feel bad! To get better at something, you must be bad at it first. Consider improvements from feedback in this thread.

Move all photos from Google takeout into one directory

Related Stories