Show HN: PatchBin.com - Pastebin for patches + comments + code review.

by antileet • 16 years ago

45 13 16 years ago

mcav• 16 years ago

I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a wider screen. Looks good though.

thwarted• 16 years ago

Agreed. 80 characters is the bare minimum for code viewing. The choice of 55, which this seems to be, is extremely odd considering it's designed to view diffs (which technically means 81 or 82 for the leading edit indicator chars).

antileet4• 16 years ago

Thanks!

I'm having a tough time with CSS right now. I hope to add a client-side way to detect when the screen is large enough and show 80 character wide views.

dimarco• 16 years ago

$(window).width() will display the viewable width of the client in jQuery. and onResize will fire on <body> when the window is resized. (food for thought)

I think this is a pretty neat idea. Often a coworker is working remotely and our boss has been begging for some code review. This could have some use.

antileet4• 16 years ago

To the folks who tried out the commenting:

A lot of comments are blank. If you entered valid text and that didn't get written to the database, and is a bug. Can you please describe any bad experience you had with the commenting system.

Thanks!

bloonlabs• 16 years ago

You might want to put a "cancel" button on the comment form. The blank comments might be people who are trying to get rid of the comment form after accidentally double-clicking.

antileet4• 16 years ago

Done! Thanks!

jestar_jokin• 16 years ago

When creating a comment, don't pop up multiple comment entry boxes.

Will you have logins and moderation etc to avoid spam?

oinopion2• 16 years ago

XSS open. http://github.com/ninjagod/patchbin/issues#issue/1

antileet4• 16 years ago

I disabled escaping because it had trouble rendering XML code. I thought it was safe but I was wrong.

Fixing now. Thanks! [edit] fixed

oinopion2• 16 years ago

I played a bit with code and I think you could benefit from reading: