Why was "goto fail;" added without any other change to that part of the code? 12 years ago
Yes people make mistakes.... that is why code in a file called sslKeyExchange.c ffs can be expected to be reviewed by another person at apple BEFORE the commit enters a release candidate. A double goto fail; is something that sticks out to anyone looking at that commit line by line. Seems like apple handles application security like any 6 dude valley startup.
My commit suggestion: - goto fail; + fail;