Marko vs. React: Performance Benchmark

https://github.com/patrick-steele-idem/marko-vs-react

by psteeleidem • 11 years ago

15 10 11 years ago

funkiee3• 11 years ago

Not necessarily addressing the speed portion, but if you're going to give a key to a repeated item in React, it is best to use the index instead of a unique identifier(if the overall DOM structure does not change much between renders) so that React does not destroy and recreate each item on tree change.

myhf• 11 years ago

It re-creates items even when they have unique identifiers? Is that a bug?

funkiee3• 11 years ago

It's as intended. If the ID in a list of 100 changes, and that ID is the key, React is going to assume the tree is different during reconciliation. If you were to use an index, like 0, on pagination the key is still 0 and as such the DOM nodes will be reused. http://facebook.github.io/react/docs/reconciliation.html See #2 in the Trade-offs section.

psteeleidem4• 11 years ago

funkiee, would you be interested in opening a Github issue or submitting a Pull Request if you believe that is the right thing to do? I'll give it a try in the meantime, but it would be great to have a public discussion on that so others don't make the same mistake (if it does indeed help). Thanks!

psteeleidem4• 11 years ago

funkiee, good catch on that issue. I just tried using the current index during iteration, instead of the actual unique ID of the search results item and that sped things up a lot. In fact, now React and Marko perform almost exactly on par for client-side rendering. Server-side rendering of React components is still very slow in comparison. I will update the README with the new results.

On a related note, the React docs were very misleading when they stated the following:

"In practice, finding a key is not really hard. Most of the time, the element you are going to display already has a unique id. When that's not the case, you can add a new ID property to your model or hash some parts of the content to generate a key." Source: http://facebook.github.io/react/docs/reconciliation.html#key...

I tried following their advice and used the unique ID of the search results record and it turns out that was the wrong thing to do. It was better to use the index of the current iteration and I think that should always be the recommended thing to do given the performance difference.

funkiee3• 11 years ago

The next sentence in your quote has some importance too, "Remember that the key only has to be unique among its siblings, not globally unique."

I agree there could be a little more clarity in that block of text, but I think the trade-offs section describes it well. Additionally, if there are any nodes in the tree that have a chance of being the same item between renders, you're going to benefit immensely from implementing a `shouldComponentUpdate` in your `SearchResultsItem.jsx` file.

React certainly doesn't win on every performance level, and if you try to compete on performance you're eventually going to lose. A careful developer could implement this list with no framework at all and have performance that beats both.

In the end, it's more about the mental model that best fits you and your team. I find the composite UI of React where I am building every component of other components in Javascript without a templating language to get in my way to be best suited to me.

If Marko works well for your team and you find it easy to get new developers on board and contributing code then that's awesome, keep up the good work.

zghst2• 11 years ago

We always see these performance benchmarks, which are great but are low on the totem pole for technology choice.

Really good questions to ask and statements to reassert:

* Does is scale well? * Will this framework / library help me in my career forward? * How hard is it to implement features? * Is the framework / library enjoyable to work in? * Does the framework / library lend itself to allowing elegant solutions? * Does the framework / library provoke a thoughtful and/or refreshing pattern or style in your code? * Is the framework / library sometimes blocking solutions to problems? * Can a new team member readily understand this, explore and contribute after a day or so of training? * How easy is it collaborating with others? * This framework / library is simple and understandable enough to get started quickly * I am intrigued by this framework / library. * There is a lot of support and resources * There aren't a lot of grey areas

As far as I know, React knocks these out of the park.

psteeleidem4• 11 years ago

This comparison benchmark was not designed to answer all of those questions. Perhaps just the following: "Does it scale well?"

The conclusion from these tests is that React currently does not scale well on the server (at least for this type of page) due to high CPU and memory usage while requests per second were low for a very modest page of 100 search results items. This is not surprising since the focus of React has been on the client-side performance, but it is important because many projects are adopting React as an "isomorphic" solution.

Hopefully the community and the authors of React can use this information to make React better. There is always something that can be learned from benchmarks like this.

React does do a good job, but I also think Marko+Marko Widgets will be a much better fit for certain types of applications since it also includes a very strong UI component model and it is lighter. If nothing else, hopefully others can learn something from looking at the code and seeing two different approaches.

zghst2• 11 years ago

I'm sure it would help if these tests used the minified version of React on the server.

Also this test could be more efficiently written. First (in SearchResults.jsx), setState accepts a callback in its second parameter, you don't need componentDidUpdate() or this.doneCallback (which is triggering more GC). Second in SearchResultsItem.jsx, you have an empty componentDidMount() function, you should get rid of that. Also this is super optimization, but it's also important that you think deeply about the creation of objects, therefore creating potential garbage that has to be cleaned up after short usage. In SearchResultsItem.jsx, you should just go with a className (className={"search-results-item" + (this.state.purchased && ' user-has-purchased')}) instead of a style object, which becomes useless if you don't have a purchase.

By giving each SearchResultsItem their own state management, you're making it more dirty than you has to be, it should just be a simple list item. Typically in this type of app (Search), the SearchResultsItem component would be stateless (no this.state, getInitialState). When someone clicks handleBuyButtonClick, that communicates the change to the store, which then flows down to SearchResults, which "re-renders" the list of SearchResultsItems.

There are probably a lot more optimizations I could go over, but in short conclusion React's performance is more than the library, it is a mode of thinking.

Marko vs. React: Performance Benchmark

Related Stories