Open-Sourcing Stripe Shop

https://stripe.com/blog/open-sourcing-stripe-shop

by DanielRibeiro • 13 years ago

104 25 13 years ago

sync• 13 years ago

Comparing this code ( e.g. https://github.com/stripe/shop/blob/master/public/assets/js/... )

to something like https://checkout.stripe.com/v2/checkout.js is like night and day. JS vs. compiled CoffeeScript. One large, monolithic file vs. obviously concatenated files. Variable naming, commenting, etc.

It's interesting -- I wonder what kind of code style guidelines they have over there, if any.

joeblau2• 13 years ago

Which one is compiled CoffeeScript? The second one? I went to a Node 0.10.0 talk [1] at AirBnB and Isaac Schluetter had some pretty funny comments for people programming in CoffeeScript.

[1] http://www.youtube.com/watch?v=zM-gUM9C5SA&t=2770

rcsorensen2• 13 years ago

Bullet points of the CoffeeScript comments:

* People don't compile to JS before publishing to NPM, making it harder to use CoffeeScript written modules.

* I don't know CoffeeScript, so it's harder to debug.

* The language is bad, introduces things from Ruby he doesn't like, there are ambiguities introduced.

When asked about ambiguities introduced, there was a reference to a "different require implementation in CoffeeScript", which has possibly since been fixed.

slexaxton3• 13 years ago

Hi, Stripe Developer here.

We have a mostly per-project set of code style and tooling guidelines. Most (if not all) of our larger projects are coffeescript and commonjs based. That's mostly because they all share at least some code. As long as a project is internally consistent and the team agrees with each other, we don't force any specific styles or tools (within reason). We have expertise with the tools we use the most though, so a lot of times the best fit is our own tools.

However, the comparison is a little bit apples and oranges. The JavaScript is optimized for reading, and maximum coherence by outside developers (an example), and the other is a compiled application for execution. The actual _source_ of the checkout project (which is not open-sourced) internally is broken up into neat files and uses modules, etc. It's quite readable for those working on the code, and the output there is generated by a computer and not really intended for humans.

Hope that helps give some insight into our process and reasoning.

rcsorensen2• 13 years ago

What are you using to stitch the modules together? Stitch, browserify, grunt/grunt-contrib and friends, something home grown?

e12e2• 13 years ago

Any plans for open sourcing the source, as well? Why/Why not?

joeblau2• 13 years ago

I just got my Stripe shirt last week :). Thanks for open sourcing this. I needed something simple like this for selling tickets.

zrail• 13 years ago

I had been hearing some rumors that this was going to be the new version of checkout.js, but this is actually better. I like it, thanks for open sourcing!

AwesomeTogether• 13 years ago

gee. i thought you had to use a javascript framework to build an spa.

alaskamiller• 13 years ago

Man, so Stripe just makes payments so easy.

Link this up with https://www.shirts.io and you get an instant t-shirt shop with no hassles.

Killswitch2• 13 years ago

Yeah man, these dev friendly API companies are awesome. Stripe, Shirts.io, EasyPost (https://www.easypost.com) Loving them all.

themgt• 13 years ago

Well, now all we need is an open source Parse-compatible server.

e12e2• 13 years ago

My thoughts exactly. I looked at the code, the demo, and then: Ok, so how can I self-host this?

I wonder if it would make sense to port this to deployd and/or helios?

I thought google app engine looked a lot more interesting when I learned of appscale -- I'd love for there to be something similar for parse.com.

Side note: deployd looks nice, although I don't think I'll be using mongodb for my projects any time soon.

mattschmulen• 13 years ago

hey, thats a good idea ! actually a great idea ...

callmeed• 13 years ago

It hasn't been updated in a while (and isn't as pretty), but I have an open-source shop for selling a digital good with Stripe:

https://github.com/2tablespoons/thylacine

powertower2• 13 years ago

With the store, you are asked for email and CC info first.

With the demo, you are asked for email and address info first.

It would be interesting to see which info entered gets the user to commit to the transaction better... That is, which one makes he/she less likely to back out; or more likely to start it.

powertower2• 13 years ago

Is it possible to take payments using Stripe without having to ask for or provide the billing address with the transaction?

I'm looking at the docs right now and it says the "address" field is optional... But how could that o.k. the transaction without the validation process (fraud check) comparing the CC's billing address (from the card network) against what the buyer supplied?

The reason I'm asking is I sell software and the billing/shipping address is useless to me.

pbiggar• 13 years ago

Yes, you can. You also don't need their card name or CVV.

jhuckestein• 13 years ago

Yes, you can charge people without the address field. You still need the CVV code for fraud protection.

I read somewhere that credit card companies charge lower rates if the address is provided as well. If that's the case, it seems like Stripe normalizes the price for you.

simonk• 13 years ago

Nope, Stripe doesn't require the CVV either.

hunvreus• 13 years ago

I have to ask: is that a 草泥马 wearing that shirt?

reustle• 13 years ago

This seems to be a response to Shopify POS being released and now they are both creeping closer and closer to each other.

Open-Sourcing Stripe Shop

Related Stories