Grep your js objects

by begriffs • 13 years ago

23 11 13 years ago

pbiggar2• 13 years ago

Looks cool. It should be straightforward to make it avoid cycles itself, and default to infinite depth, which feels like a better default than 5.

begriffs3• 13 years ago

Actually it does mark visited objects to avoid cycles in its search. The default depth limit prevents it from taking too long on huge dom objects, but the choice of an arbitrary depth limit (of 5) does seem kind of gross. I'm open to suggestions for improvement.

pbiggar2• 13 years ago

Oh cool. The readme (at the very bottom) makes it appear like it doesn't mark visited objects.

indubitably• 13 years ago

            if (i.match(/^[$A-Z_][0-9A-Z_$]*$/i)) {

broken

begriffs3• 13 years ago

You're saying it is too simple of a regex to reliably match well-behaved js identifiers? Or is it broken in another way as well?

What would you suggest as a better test?

shurcooL• 13 years ago

I would like something like this for getting fields/values from nested Go structs.

Does something like that already exist, or will I have to write it?

solox3• 13 years ago

Wouldn't it be better if the return is just a list of either the result (in the case that the value of a KV pair matches), or a reference to the result (in the case that the key of a KV pair matches)?

oinksoft• 13 years ago

A small thing: If you are targeting Chrome, or modern browsers in general, use

  Object.defineProperty(Object.prototype, 'grep', {
    enumerable: false,
    value: /* ... */
  });

rather than

  Object.prototype.grep = /* ... */

This way, your 'grep' does not pollute for () loops.

begriffs3• 13 years ago

Fixed.

Great suggestion, thank you!

underwires• 13 years ago

nice use of jabberwocky - I think I'll switch my lorem ipsum to that.

chadscira• 13 years ago

this will be very useful when trying to reverse engineer something :).

Grep your js objects

Related Stories