Automatically add missing "async/await" keywords to your TypeScript code

https://github.com/stanNthe5/typescript-autoawait

by theThree • 1 year ago

7 7 1 year ago

github.com

bastawhiz• 1 year ago

Is this a problem that people actually have?

xeromal• 1 year ago

Fun side project man!

primitivesuave• 1 year ago

I took a peek at the implementation - I think this only works for a case where the typing explicitly contains the string "Promise". For example, I don't think it would work if I use `SomeInterface["some_promise_key"]` or might incorrectly add an async if I use `Awaited<Promise<...>>`.

I think what you're trying to build might be best served by Typescript's VFS - https://www.npmjs.com/package/@typescript/vfs. You can load the local files into an in-memory type system, and quickly extract async/await hints that might be more useful for a typical TS developer. I think there's a lot of really interesting static analysis you could do to improve async/await safety, as it certainly leads to issues from time to time.

joshstrange• 1 year ago

I do not want to be mean but I think you'd be much better served with ESLint rules to yell at you when you don't await when you should or do when you shouldn't.

This should _not_ be an automatic operation since it can change behavior in ways that will be unclear to the developer (completely undoing any gain from them being added automatically).

theThree• 1 year ago

You can still control it by adding "//no-await". In fact, the "//no-await" makes me feel more clear.

nextweek22• 1 year ago

I created a ticket, using comments is not necessary because there is already the `void` syntax for when you don't want to wait:

https://github.com/stanNthe5/typescript-autoawait/issues/1

nextweek22• 1 year ago

It should be noted that there is already a lint rule for this: https://typescript-eslint.io/rules/no-floating-promises/

Automatically add missing "async/await" keywords to your TypeScript code

Related Stories