Show HN: c

by Jonovono • 14 years ago

54 60 14 years ago

redbad• 14 years ago

    And those on Mac should be able to use:
    
    $ brew install c

Wow, uh, didn't it strike you that this might be a bad idea?

sharth• 14 years ago

As far as I can tell, this program is not included in Homebrew.

Jonovono11• 14 years ago

hmm. It should be. You may just have to run brew update? It wasn't added very long ago so you may not see it if brew has not been updated. If it still doesn't work then not sure.

Jonovono11• 14 years ago

ha, no, afraid it didn't. I have installed other programs from brew that were one character. But I plan to rename it just to comment and then provide instructions on how to alias it to c if one would wish. Thanks for warning.

gouranga• 14 years ago

Great idea - I think 'c' should be a shell alias though.

Tagging support would be cool.

Jonovono11• 14 years ago

Thanks!

And yeah, didn't think of that. It would be neat to be able to tag files or directories and then execute a command to see all the directories with that tag and then enter that directory easily. Maybe i'll try adding that to the next version. Can you think of anything else that would be useful?

davyjones• 14 years ago

Terrible, terrible name.

veyron2• 14 years ago

i agree that no program should have 1 character name, but what do you currently alias 'c' to?

suraj• 14 years ago

clear screen

tptacek6• 14 years ago

"Repeat `argv[2]` on stdout `argv[1]` times."

i.e., "c 128 A" -> AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA.

Pentesters! :)

Jonovono11• 14 years ago

sorry! I just wanted a simple thing to type to add a comment. I was going to call it comment but just shortened it to c.

zhov2• 14 years ago

I would rename it to something else and just alias it to 'c'.

swordswinger12• 14 years ago

This is really cool! Thanks for sharing.

Jonovono11• 14 years ago

Thanks! Glad you like it.

zhov2• 14 years ago

I'd also like to point out that the Twitter account you link to for contact looks extremely inactive.

Jonovono11• 14 years ago

It is. But I plan to start using it. I just started using twitter and only really plan to use it to share projects I work on or communicate with others!

axitanull• 14 years ago

Googling topics on "C" has been tough for me for the past 15 years.

Bonus point for me trying to filter out C++.

leif5• 14 years ago

Comments for your C learning:

    #include <stdbool.h>

is better than

    typedef int bool;
    #define true 1
    #define false 0

Always, always, surround your if and else clauses with brackets. There are plenty of ways leaving them naked will screw you over. This goes for any language.

This is terrifying, and broken:

    char * s = malloc(snprintf(NULL, 0, "%s/%s", cwd, argv[1]) + 1);
    sprintf(s, "%s/%s", cwd, argv[1]);

Passing NULL to snprintf, first of all, should be a huge red flag for you. If it's not, train yourself to recognize it. I realize what you're trying to do, but it relies on non-portable behavior. In particular, from the manual:

    The glibc implementation of the functions snprintf() and vsnprintf() conforms
    to the C99 standard, that is, behaves as described above, since glibc version
    2.1.  Until glibc 2.0.6 they would return -1 when the output was truncated.

So until glibc 2.0.6, your program would be allocating 0 and then sprintfing into it. Always be careful when you read the manual, to read everything. And even then, program defensively, and train yourself to watch for errors like this one. In this case, passing NULL as the destination argument was an immediate no-no.

In this function, you really should be checking errno (for ENOENT). stat(2) can fail for all sorts of reasons, one of them is that the entry is not there.

    bool dirOrFileExists(const char dir[]) {
	struct stat st;
	if (stat(dir, &st) == 0) {
		return true;
	}
	else {
		return false;
	}
    }

Same for this loop, check errno to make sure the function's failing for the reason you think it should.

    while((entry = readdir(mydir)))

Here, you have something a little messy:

    int fileOrDirectory(const char path[]) {
	struct stat s;

	if (stat(path, &s) == 0) {
		if (s.st_mode & S_IFDIR) {
			// Is a directory
			return 0;
		} else if (s.st_mode & S_IFREG) {
			// Is a file
			return 1;
		} else {
			// Something else
			return -1;
		}
	}
	else {
		// Error
		printf("Error occurred\n");
	}
    }

First of all, returning values only you know about is bound for destruction. You should define an enum if you want a function to return specific states. Better yet, just do these checks in the function that would normally call this. It's not so bad usually, and you're probably calling stat(2) more than you should. It's a syscall, and those can be expensive. But more importantly, you have a branch where all you do is print something (to stdout, not stderr as you should), and then just return nothing! If you hit an error state, you need to either propagate that error up and handle it in the caller, or crash immediately. Don't leave your program in a garbage state and keep going. A compiler should have warned you about this (not having a return value in one branch). Turn on -Werror and at least -Wall. And fix your warnings, don't try to suppress them.

You should use fscanf(3) instead of this:

    while (1) {
	ch = fgetc(fp);
	newch[i] = ch;
	if (ch == EOF) {
		newch[i] = '\0';
		break;
	}
	i++;
    }

That's all for now, I gotta go. Good luck!

fsaintjacques• 14 years ago

I'm not the author but I would like to thank you for the constructive comment. You make the internet a better place.

databus2• 14 years ago

I see 17 mallocs and not one free!

JoachimSchipper3• 14 years ago

That's acceptable for a command-line program that will terminate quickly. It's debatable whether this is good style, but it doesn't actually hurt.

leif5• 14 years ago

get sum valgrind up in hurrr

JoachimSchipper3• 14 years ago

Some additional stuff which jumped out at me, on top of leif's excellent collection:

+ cwd[] should be MAXPATHLEN bytes long

+ if you want people to use it, you need to put some license on it. GPL and ISC (simplified BSD) are good choices.

+ you may wish to consider asprintf() and err() (both of which elegantly solve a problem that leif has pointed out). These functions are non-POSIX but widely supported and easily portable. (You can also learn how to use the autotools to handle OSes that do not have these functions.)

+ getopt_long() may be easier than parsing parameters "by hand", especially once your utility grows more parameters.

+ hardcoding the colours is ok for now, but you should really use terminfo to find the appropriate escape sequence. The "magic word" for setting the foreground colour is "setaf"; you may wish to look at terminfo(3) and the source code for tput, if your OS has that utility. Warning: proper terminal handling is complex.

lubutu3• 14 years ago

"cwd[] should be MAXPATHLEN bytes long"

This is actually a common mistake — PATH_MAX and the like are not guaranteed to be defined. In fact, in POSIX it is literally impossible to ever know whether your buffer is long enough. Your best bet is,

  #ifdef PATH_MAX
  char cwd[PATH_MAX];
  long len = sizeof cwd;
  #else
  char *cwd;
  long len;
  if((len = pathconf(".", _PC_PATH_MAX)) < 0)
    len = 8192; /* some arbitrary value */
  cwd = malloc(len);
  #endif

This is probably one of the ugliest parts of POSIX.

tptacek6• 14 years ago

I think it's a little strange to take someone to task for using C99 snprintf and then turn around and tell them to use asprintf. The reality is that both snprintf and asprintf are equally portable --- there was a window in the '90s where snprintf was by itself not portable, and projects routinely carried it along.

This is all academic though; dynamic sizing for a buffer containing a Unix path passed in on the command line? Professional code would just use PATH_MAX or whatever and be done with it. I see downthread that there are concerns about path limits, but since so much of the rest of Unix doesn't care about that particular problem, I'm not sure what the win is trying to optimize it.

haberman• 14 years ago

> So until glibc 2.0.6, your program would be allocating 0 and then sprintfing into it.

glibc 2.0.6 was released in 1997. I do not think it is reasonable to ask that applications accommodate bugs in libc that have been fixed for 15 years. If someone was actually using a system that old, their system will have so many unpatched vulnerabilities that this will be the least of their problems. And it's highly unlikely that every such bug is documented in the manpages anyway.

leif5• 14 years ago

It illustrates a more general problem, that's all.

lubutu3• 14 years ago

glibc is not the only libc in existence. It is reasonable to ask that applications support systems other than those developed by GNU.

tptacek6• 14 years ago

It's not really a "bug". C99 adopted snprintf(), which had become a de facto standard in POSIX code prior to C99, and with it adopted a feature (formatting "into" NULL to get the length of the required buffer) that was not universally implemented.

It's a portability issue.

If you really truly cared about maximum portability, you'd just take a libc snprintf() that did the NULL-size thing and bundle it with your project, just like the AIX version of Sendmail bundled snprintf() because the platform didn't have it.

Or, even better: JETTISON THE PRINTF FAMILY and replace it with something that lets you register your own format codes. This is all ANSI C string manipulation and this code compiles small and in milliseconds.

But in this case the whole discussion is silly because the dynamic string buffer here is not only overengineered (both Unix paths and command line arguments have size restrictions and so dynamic sizing is silly) but also non-idiomatic.

Jonovono11• 14 years ago

This is awesome, thanks! I just started learning C and am just beginning going through "The C programming language" so thanks for the advice! I definitely plan to improve the program, or feel free to submit a revision!

leif5• 14 years ago

You should also get in the habit of compiling with warnings (-Wall -Wextra -Werror) and running with valgrind. And writing test programs (in this case they could be shell scripts, unless you want to split your code into a library and an executable, so you can test the library with c programs. That lets you run your tests with valgrind.

ajanuary• 14 years ago

    if (getcwd(cwd, sizeof(cwd)) != NULL)
        ;
    else
        perror("getcwd() error");

Is that common? What's the advantages over the below?

    if (... == NULL) {
        perror(...);
    }

tptacek6• 14 years ago

No, it's not common. This is not idiomatic C code (not that that's an intrinsic problem).

markdrago• 14 years ago

It may be more appropriate to store the comments in extended attributes rather than in dotfiles: http://en.wikipedia.org/wiki/Extended_file_attributes

zephyrfalcon• 14 years ago

4DOS used to have this. It was especially useful back in the day with the 8.3 DOS filenames, which often weren't very descriptive. It's nice to see this feature return.

jcromartie• 14 years ago

Hidden files are handy for some things, but a README.txt file would be apparent to anybody who comes across the directory, and not just someone who knows that the hidden directory is/may be there.

mccoyst• 14 years ago

Why did you decide to use autoconf?

ga2arch• 14 years ago

Wouldn't it be better to use Extended file attributes ? https://gist.github.com/2695264 (actually my first attempt to a bash script)

Jonovono11• 14 years ago

Cool! Yeah I looked into them but didn't quite understand. I'll take another look. Thanks for the gist you made.

brimpa• 14 years ago

I'd prefer to have all the comments located in a single location (e.g. ~/.comments or ~/Dropbox/comments-<hostname>) rather than litter hidden files all over the place because I could (1) easily back them up, (2) share them (even across different platforms), and (3) allow multiple users to set local and global (shared) comments.

EDIT

Because I was bored: https://gist.github.com/2697095

azelfrath• 14 years ago

As a sub-novice C/++ programmer myself, it's awesome to see a program like this being discussed. The source code is relatively short, it's a simple enough implementation, and all the feedback in the comments here is teaching me things I wouldn't necessarily be exposed to in a book.

Jonovono11• 14 years ago

Yeah! I am happy with the feedback. I just made this because I thought it would be useful for me and to help learn C since I just got K&R book. Also, I know people are always looking for open source projects to submit to so this would be perfect to try out as there are most likely (as pointed out in the comments) many things that can be improved!

mfonda• 14 years ago

I love this post and the exchange of comments going on here. The OP is just starting to learn C, and to help learn it got started on a project that they found useful, which I think is one of the best ways to learn programming.

The community then responded by posting helpful feedback, much of which demonstrates the idiomatic way of doing things, which is often one of the most difficult things to learn when picking up a new programming language. Other helpful advice is posted on build options and debug tools.

This kind of constructive and useful feedback is great to see.

Show HN: c

Related Stories