Crashes in HTTP server used in routers found with simple fuzzing

https://github.com/cybergarage/mupnp/issues/21

by costco • 3 years ago

54 4 3 years ago

costco2• 3 years ago

Discovered some bugs in an HTTP library used in upnp software found in Zyxel and some other brands routers. Unfortunately no code execution but did get reliable crashes!

All it took was honggfuzz and ~30 lines of code:

    #include <string.h>
    #include <unistd.h>
    #include <mupnp/http/http.h>

    #define MUPNP_TESTCASE_HTTP_PORT 8080
    #define MUPNP_TESTCASE_HTTP_PAGE "<HTML><BODY>Hello World</BODY></HTML>"
    #define MUPNP_TESTCASE_HTTP_URL "/index.html"

    void ClinkTestcaseHttpRequestRecieved(mUpnpHttpRequest* httpReq) {
      mUpnpHttpResponse* httpRes;

      httpRes = mupnp_http_response_new();
      mupnp_http_response_setstatuscode(httpRes, MUPNP_HTTP_STATUS_OK);
      mupnp_http_response_setcontent(httpRes, MUPNP_TESTCASE_HTTP_PAGE);
      mupnp_http_response_setcontenttype(httpRes, "text/html");
      mupnp_http_response_setcontentlength(httpRes, strlen(MUPNP_TESTCASE_HTTP_PAGE));
      mupnp_http_request_postresponse(httpReq, httpRes);
      mupnp_http_response_delete(httpRes);
    }

    HFND_FUZZING_ENTRY_FUNCTION(int argc, const char *const argv[]) {
        mUpnpHttpServer* httpServer = mupnp_http_server_new();
        mupnp_http_server_open(httpServer, MUPNP_TESTCASE_HTTP_PORT, NULL);
        mupnp_http_server_setlistener(httpServer, ClinkTestcaseHttpRequestRecieved);
        mupnp_http_server_start(httpServer);

        while (1) {
          sleep(1);
        };

        mupnp_http_server_stop(httpServer);
        return EXIT_SUCCESS;
    }

phh• 3 years ago

There was some "reference" upnp implementation (I don't remember where it came from, but it was used in real products) where you could do http://<hostname>/getfile/$(echo ../../etc/passwd |base64) ... and get /etc/passwd.

costco2• 3 years ago

I wasn't expecting this to get much attention because it didn't require very much effort on my part but it looks like someone has smiled upon on my post :) Anyways, this is the kind of thing a simple setup can find, see mongoose's (another embedded web server) fuzzer in oss-fuzz: https://github.com/google/oss-fuzz/blob/master/projects/mong....

olliej• 3 years ago

Fun story, when first developing the web socket protocol we had to deal with kind of nonsense (especially for large commercial routers that did "deep packet inspection"). The solution is that the websocket protocol essentially does this:

1. generate random key

2. send random key (no key exchange, just send the raw bytes)

3. starting sending data, encrypted using the key from (2)

This is because so many routers try to analyze traffic going through them (especially those big commercial ones with "deep packet inspection"), but are really bad at it. As a result providing arbitrary JS running on arbitrary webpages exact bit level control of the data stream would allow people to compromise routers. The same basic issue came up when java applets were first a thing and the result was significant restrictions on networking by applets

Alas the whole point of websockets was to give sites "arbitrary byte" streams so the solution was to make it so that while you had complete logical control of the bytes the actual bytes on the wire are opaque to the JS running in the browser. The goal was not to protect the privacy or confidentiality of the data stream, but to ensure that no existing router software could read the stream and then try to inspect it without knowing that they were parsing arbitrary data, and any new implementation that did try would have hopefully learned about the danger of parsing arbitrary data badly (hint: they did not)

[edit: add extra new lines to the list]

Crashes in HTTP server used in routers found with simple fuzzing

Related Stories