HNGlance

Top Best New Show

Those pesky pull request reviews

https://jessitron.com/2021/03/27/those-pesky-pull-request-reviews/

by ifcologne • 5 years ago

2 1 5 years ago

JE

Related Stories

Loading related stories...

Comments

1

datavirtue• 5 years ago

It's for compliance mostly. So whichever regulator sees that you have a code review checkpoint. I look for obvious things like tests with missing edge cases, copy pasta violations, and embarrassing things they missed.

If you have static code analysis, automated pipelines, and tests you shouldn't be stressed out about code reviews and they should be fast.

If I am on good terms with the dev and we have time (LOL) I might try to help them refactor something for clarity.

Source preview

jessitron.com

HNGlance

© 2024-2026 HN Glance. Story content belongs to its original sources.

Privacy
Terms