Pulley: Easy Github Pull Request Landing

http://ejohn.org/blog/pulley/

by mark_h • 15 years ago

29 5 15 years ago

ejohn.org

eapen• 15 years ago

Requires node.js

Github link: https://github.com/jeresig/pulley

decklin• 15 years ago

I don't get it. Why not git merge --no-ff and put your formatted message in the merge commit?

jeresig2• 15 years ago

While --no-ff is certainly useful it doesn't really do anything to clean up the stream of the (most likely, redundant) pull request. Pulley reduces it to a single commit instead (which I, and other contributors to jQuery, tend to prefer) and yet still closes the pull request automatically (which --squash doesn't handle).

(Some anecdotal experience: I believe that some members of the jQuery team tried to use --no-ff but it didn't seem to yield a result that reliably closed bugs on our bug tracker - not sure what the root cause was. Either way, it's not providing a formatted message, which is something that we want.)

MBlume• 15 years ago

I guess I'm confused about what you mean by "clean up the stream" and why you find it desirable. If someone fixes a bug by making five small changes, and documents each change with an intelligent commit message, I want those five commits in my history as-is. This also saves the contributor from having to rebase their repository.

Pulley: Easy Github Pull Request Landing

Related Stories